Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candid test suite: Write a few more spacebomb tests #479

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Oct 17, 2023

Just to test a few more corner cases and variants.

@ghost ghost added the cla:agreed label Oct 17, 2023
@nomeata
Copy link
Collaborator Author

nomeata commented Oct 17, 2023

The CI seems to fail for unrelated reasons?

    Checking pretty-hex v0.2.1
error: slow zero-filling initialization
   --> rust/candid/src/types/value.rs:455:17
    |
454 |                 let mut buf = Vec::new();
    |                               ---------- help: consider replacing this with: `vec![0; len]`
455 |                 buf.resize(len, 0);
    |                 ^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization
    = note: `-D clippy::slow-vector-initialization` implied by `-D clippy::all`

@chenyan-dfinity chenyan-dfinity merged commit c342311 into master Oct 17, 2023
2 checks passed
@chenyan-dfinity chenyan-dfinity deleted the spacebomb-tests branch October 17, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants